Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set sync_time_with_host to default to true #2120

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix: set sync_time_with_host to default to true #2120

merged 1 commit into from
Jan 23, 2024

Conversation

vasilsatanasov
Copy link
Contributor

@vasilsatanasov vasilsatanasov commented Jan 22, 2024 •
edited by tenthirtyam

Description

  • Changed the default value for sync_time_with_host in r/vsphere_virtual_machine to true to align with default value provided by the UI.
  • Updated documentation

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Testing Done:

  1. Created VM before changes - syncTimeWithHostAllowed was false
  2. After the changes without explicit configuration syncTimeWithHostAllowed was equal to true

Release Note

`r/virtual_machine`: Changed the default value for `sync_time_with_host` in `r/vsphere_virtual_machine` to `true` to align with default value provided by the UI.

References

Closes #1443

@vasilsatanasov vasilsatanasov requested a review from a team as a code owner January 22, 2024 16:22
@tenthirtyam tenthirtyam added the bug Type: Bug label Jan 22, 2024
@tenthirtyam tenthirtyam added this to the v2.7.0 milestone Jan 22, 2024
@tenthirtyam tenthirtyam changed the title Set sync_time_with_host to default to true fix: set sync_time_with_host to default to true Jan 22, 2024
@vasilsatanasov @tenthirtyam
fix: set sync_time_with_host to default to true
a75cccb 
Changed the value for `sync_time_with_host` to default to `true` for`r/vsphere_virtual_machine` in compliance with the default value provided by the UI.

Signed-off-by: Vasil Atanasov <vasila@vmware.com>
@tenthirtyam tenthirtyam force-pushed the topic/vasilsatanasov/issue-1443 branch from 8b85994 to a75cccb Compare January 22, 2024 22:03
tenthirtyam
tenthirtyam approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam merged commit c0e3f00 into hashicorp:main Jan 23, 2024
4 checks passed
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
@tenthirtyam tenthirtyam linked an issue Mar 6, 2024 that may be closed by this pull request
sync_time_with_host behavior change in v2.7.0 #2148
Closed
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

@iBrandyJackson iBrandyJackson iBrandyJackson approved these changes

Assignees

@vasilsatanasov vasilsatanasov

Labels
bug Type: Bug
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.

sync_time_with_host behavior change in v2.7.0 sync_time_with_host incorrectly defaults to false
3 participants
@vasilsatanasov @tenthirtyam @iBrandyJackson