[IMPL] Add implicit conversion from RECT -> System.Drawing.Rectangle. #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes terrafx#387. Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
Comment on lines
+31
to
+32
| public static implicit operator Rectangle(RECT rectangle) | ||
| => Rectangle.FromLTRB(rectangle.left, rectangle.top, rectangle.right, rectangle.bottom); |
There was a problem hiding this comment.
This isn't safe to be implicit, as it potentially overflows and thus is lossy.
Comment on lines
+35
to
+36
| => new | ||
| { |
There was a problem hiding this comment.
nit: target typed new is one of my least favorite language features and I'm pretty sure it's blocked in the editorconfig, so I expect this will cause CI to fail.
|
Same general feedback as given on the issue. I'm not particularly a fan of this, as its potentially lossy and brings in a new dependency. This really seems like something where a user could provide extension methods for their own library to solve the need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal Implementation
Adds an implicit conversion operator from
RECT->Rectanglewith an explicit operator fromRectangleback toRECTwhen the rectangle needs converted to anRECTfor calls into Windows APIs that requires it. Also with operators handling these conversions programmers would worry less on if they got their conversion betweenRECT<->Rectanglecorrect or not by eliminating all the guess work from it. Unit tests of the operators will come soon. As such I opened this pull request as a draft.Implements/Fixes #387.