Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity navigation without supporting Fragments #77

Closed
amitav13 opened this issue Aug 20, 2018 · 2 comments
Closed

Activity navigation without supporting Fragments #77

amitav13 opened this issue Aug 20, 2018 · 2 comments

Comments

@amitav13
Copy link

Hi,
As it stands, SupportAppNavigator forces support for both Activity and Fragments when implementing it. If I'm refraining from using fragments altogether, then it doesn't make as much sense for me to put in a containerId(which needs a primitive int value) and to override createFragment and pass back an arbitrary non-null Fragment.

While it is easy enough to override the Navigator interface and build my own Activity-only navigator, it would be nice if we could have one in the library ready to use, out-of-the-box. Could contribute this myself too. Thoughts?

@terrakok
Copy link
Owner

I think that Single-Activity application is right way. But if you need only activity navigator, you can do it easy himself 😉

@amitav13
Copy link
Author

amitav13 commented Oct 2, 2018

I did end up writing this myself, for anyone interested: https://gist.github.com/amitav13/7f8d702cd42bf02efe994be36d5ee28f

@amitav13 amitav13 closed this as completed Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants