Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-10] Support Single Targets and Native-Grouped Targets #11

Merged

Conversation

brady-aiello
Copy link
Contributor

[Summary]

Some dependencies are only applicable to 1 target, and some apply to all
native targets (except WASM, which almost no one supports yet). It would
be nice to add in some target-specific dependencies, especially when
they relate closely to a shared dependency (Ktor and SQLDelight are
examples).

[Fix]

Create a "Single Target Libraries" and a "Native Target Libraries"
section. Single Target libraries are available as long as there is a
target selected that supports it. Native Target Libraries are available
as long as there is at least one native target it builds for (excluding
WASM).

[Testing]

  • ./gradlew check
  • manual testing

The following selection:

Screen Shot 2021-12-12 at 5 49 36 PM

Produces:

Screen Shot 2021-12-12 at 5 50 02 PM
#10

[Summary]
Some dependencies are only applicable to 1 target, and some apply to all
native targets (except WASM, which almost no one supports yet). It would
be nice to add in some target-specific dependencies, especially when
they relate closely to a shared dependency (Ktor and SQLDelight are
examples).

[Fix]
Create a "Single Target Libraries" and a "Native Target Libraries"
section. Single Target libraries are available as long as there is a
target selected that supports it. Native Target Libraries are available
as long as there is at least one native target it builds for (excluding
WASM).

[Testing]
- `./gradlew check`
- manual testing
@terrakok terrakok merged commit 09e566b into terrakok:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants