Remove silent overwriting of shutil.copy in ARMI utils

[opotowsky]

safeCopy silently overwrites shutil.copy in ARMI:

armi/armi/utils/__init__.py

Lines 807 to 825 in 08f8c1d

	def safeCopy(src: str, dst: str) -> None:
	"""This copy overwrites ``shutil.copy`` and checks that copy operation is truly completed before continuing."""
	waitTime = 0.01 # 10 ms
	if os.path.isdir(dst):
	dst = os.path.join(dst, os.path.basename(src))
	srcSize = os.path.getsize(src)
	shutil.copyfile(src, dst)
	shutil.copymode(src, dst)
	while True:
	dstSize = os.path.getsize(dst)
	if srcSize == dstSize:
	break
	time.sleep(waitTime)
	runLog.extra("Copied {} -> {}".format(src, dst))
	# Allow us to check the copy operation is complete before continuing
	shutil_copy = shutil.copy
	shutil.copy = safeCopy

I'm making this ticket so that when shutil.copy is replaced in all downstream plugins with safeCopy, I want to remove this menace from the code base.

I also need to check in with other ARMI users so they have a heads up on a potentially breaking change (so, if shutil is being leveraged, they can do nothing and revert to the real shutil.copy, or they can also swap to explicitly using safeCopy)

[john-science]

I agree, silently over-writing a standard library tool whenever you import armi is a bad solution to whatever problem this was trying to solve.

I would say "let's do it right now!", but since it's an API-breaking change, we will be slow and deliberate.

@drewj-usnctech Just FYI.

[onufer]

this seems super low priority. I agree it is confusing and surprising but its going to be a lot of work to change and very little benifit.

[opotowsky]

Thanks for reopening @onufer

I grepped around and it won't be a huge lift. I agree it's low priority, but I'd like to get in the habit of paying back some tech debt and this is an easy one.