Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server side] Guard against running bundler and rake tasks in local environment #74

Closed
Bootjack opened this issue Jul 1, 2018 · 2 comments

Comments

@Bootjack
Copy link
Contributor

Bootjack commented Jul 1, 2018

This project is set up to use Docker to help reduce the burden of configuring a new local development environment for every new contributor. It works great when it works, but an obvious flaw is that any developer can still run the app in their local environment, which may introduce the very environment-specific discrepancies that Docker is supposed to ward off, such as bundler version warnings.

I'm sure a talented open-source community member can figure out a way to prevent running rails directly in a local environment, or at least warn the developer about it. Either way, we should provide clear messaging with links to our documentation about the correct way to run rails-y stuff in this project.

@DarthHater
Copy link

This could likely be accomplished using .dockerignore, to prevent any bundler specific stuff (I can't remember where bundler stores stuff, but maybe it's in /vendor?) from making it into Docker via the COPY . .. Having worked on a similar Rails project (https://github.com/DCAFEngineering/dcaf_case_management), we ended up being pretty happy at the end of the day by just documenting how to run something locally, and via Docker, and suggesting Docker overall.

@rudokemper rudokemper changed the title Guard against running bundler and rake tasks in local environment [Server side] Guard against running bundler and rake tasks in local environment Apr 11, 2019
@rudokemper rudokemper added this to the Terrastories as a Service milestone Apr 11, 2019
@mirandawang
Copy link
Contributor

closing for now; moving details to issue google doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants