Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a 'recompile' button #133

Open
carine-laine opened this issue Mar 3, 2024 · 2 comments · May be fixed by #141
Open

Add a 'recompile' button #133

carine-laine opened this issue Mar 3, 2024 · 2 comments · May be fixed by #141
Assignees
@BarryNolte

Comments

@carine-laine
Copy link

Use case: Working with imports and several files, diagram preview on the right side. When I update one of the imported files, I have to go back to the diagram file and hit save to refresh the preview. It'd be better if I could just click on a button in the preview itself.

Visually, that would be something like the Obsidian plug-in (although it doesn't seem to support imports at all)
image
@BarryNolte
Copy link
Collaborator

After giving this some thought, the 'refresh/recompile/F5' button is the way to go. I had thought to put a file watch on the imports, but that leads me down the rabbit hole of keeping track of imports, imports that import (and so on), additions to the imports and deletions of the imports. All of course doable, but that is a bug factory, and a refresh button is causing something to happen that is already coded to happen.

I've got a large PR I'm working on, but I'll get to this right after that gets accepted.

@BarryNolte BarryNolte self-assigned this Mar 4, 2024
@carine-laine
Copy link
Author

I agree - KISS.

BarryNolte added a commit to BarryNolte/d2-vscode that referenced this issue Mar 31, 2024
@BarryNolte
Add a 'recompile' button
c9d3162 
Fixes terrastruct#133
@BarryNolte BarryNolte linked a pull request Mar 31, 2024 that will close this issue
Open
BarryNolte added a commit to BarryNolte/d2-vscode that referenced this issue Mar 31, 2024
@BarryNolte
Add a 'recompile' button
99bbb27 
Fixes terrastruct#133
BarryNolte added a commit to BarryNolte/d2-vscode that referenced this issue Apr 23, 2024
@BarryNolte
Add a 'recompile' button
3b0ddc1 
Fixes terrastruct#133

This was fun.  Tasks *really* want to be asynchronous, but I needed them to be synchronous.
BarryNolte added a commit to BarryNolte/d2-vscode that referenced this issue Apr 23, 2024
@BarryNolte
Add a 'recompile' button
4f8b2c1 
Fixes terrastruct#133
BarryNolte added a commit to BarryNolte/d2-vscode that referenced this issue May 7, 2024
@BarryNolte
Add a 'recompile' button
aa0c072 
Fixes terrastruct#133
BarryNolte added a commit to BarryNolte/d2-vscode that referenced this issue May 15, 2024
@BarryNolte
Add a 'recompile' button
22f66e3 
Fixes terrastruct#133
BarryNolte added a commit to BarryNolte/d2-vscode that referenced this issue May 17, 2024
@BarryNolte
Add a 'recompile' button
82b93df 
Fixes terrastruct#133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BarryNolte BarryNolte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a 'recompile' button BarryNolte/d2-vscode
2 participants
@BarryNolte @carine-laine