Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grid in constant near #1173

Merged
merged 4 commits into from
Apr 10, 2023
Merged

grid in constant near #1173

merged 4 commits into from
Apr 10, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Apr 10, 2023 •
edited

Summary

Fixes grid layout not being applied on an object with a constant near value.

Details

  • fixes grid and near #1172
  • adds grid_in_constant_near test
  • when grids were added, constant nears couldn't be containers but now they can be

before/after

Screen Shot 2023-04-10 at 10 35 34 AM

@gavin-ts gavin-ts requested a review from a team April 10, 2023 17:39
@gavin-ts gavin-ts marked this pull request as ready for review April 10, 2023 17:39
@gavin-ts gavin-ts enabled auto-merge April 10, 2023 17:39
@gavin-ts gavin-ts merged commit 0032c5c into terrastruct:master Apr 10, 2023
2 checks passed
@ZhongRuoyu ZhongRuoyu mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grid and near
2 participants
@gavin-ts @alixander