Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply font size to markdown #1191

Merged
merged 5 commits into from
Apr 13, 2023
Merged

apply font size to markdown #1191

merged 5 commits into from
Apr 13, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Apr 13, 2023 •
edited

Summary

Apply font size to markdown

Details

  • fixes font-size doesn't work for markdown texts #529
  • adds md_fontsize_10 test
  • update markdown rendering with font-size
  • update markdown measurement to account for font-size
  • for containers that are md text (should this be valid?), don't apply label font-size increase

before (default font-size 16)

Screen Shot 2023-04-12 at 8 26 36 PM

after (font-size 10)

Screen Shot 2023-04-12 at 8 26 45 PM

@gavin-ts gavin-ts marked this pull request as ready for review April 13, 2023 03:27
@gavin-ts gavin-ts requested a review from a team April 13, 2023 03:27
@gavin-ts gavin-ts enabled auto-merge April 13, 2023 03:29
alixander
alixander approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. tested on all the browsers

@gavin-ts gavin-ts merged commit 60d2b0e into terrastruct:master Apr 13, 2023
2 checks passed
@ZhongRuoyu ZhongRuoyu mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

font-size doesn't work for markdown texts
2 participants
@gavin-ts @alixander