Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple constant nears #1591

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Fix multiple constant nears #1591

merged 5 commits into from
Sep 19, 2023

Conversation

gavin-ts
Copy link
Contributor

Summary

Fixes a layout bug when there are multiple constant nears that are larger than the rest of the diagram.

Details

  • adds multiple_constant_nears test
  • fixes layout order for multiple constant nears
  • center-left and center-right weren't being placed before corners

before/after

Screenshot 2023-09-18 at 9 02 13 PM

@gavin-ts gavin-ts marked this pull request as ready for review September 19, 2023 04:25
alixander
alixander approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, good one

@gavin-ts gavin-ts merged commit 833843a into terrastruct:master Sep 19, 2023
2 checks passed
@Porkepix Porkepix mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gavin-ts @alixander