Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: fix dagre container-child connections #71

Open
gavin-ts opened this issue Nov 11, 2022 · 0 comments
Open

layout: fix dagre container-child connections #71

gavin-ts opened this issue Nov 11, 2022 · 0 comments
Labels
bug Something isn't working layout

Comments

@gavin-ts
Copy link
Contributor

gavin-ts commented Nov 11, 2022

dagre doesn't handle container connections so the solution is to connect to a container's child, then cut the edge at the container's border. This works well if something outside is connecting to the container, but if it is from a child/descendant, then it will show up as an edge between descendants. Perhaps we can add a dummy node outside the container, and use that for connections going to a container from a descendant.

example:

container.first -> container.second: 1->2
container -> container.second: container->2

dagre layout (incorrect edge)

Screen Shot 2022-11-11 at 3 29 24 PM

tala layout

Screen Shot 2022-11-11 at 3 29 36 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working layout
Projects
Status: No status
Development

No branches or pull requests

1 participant