Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spa custom regex expression #88

Open
ethanaobrien opened this issue Apr 28, 2022 · 7 comments
Open

spa custom regex expression #88

ethanaobrien opened this issue Apr 28, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@ethanaobrien
Copy link
Collaborator

I made a spa app and I now finally realize why you would want to have a custom regex expression.

The current one is /.*\.[\d\w]+$/ which basically means if the file (it basically pops after the last /) has a . (dot) and then something after the dot then the spa page will not (since we want it to be null) be rendered. A custom regex would allow the user to only render the spa html with something like a certain extension or a specific folder in the path or something like this.

Going back to this (I couldnt find the exact location but I remember the conversation)

spa does NOT just render the page when no file is found, it renders the page when the regex expression is not met.

Let me know what you think

@terreng
Copy link
Owner

terreng commented May 11, 2022

I understand how the custom regex feature works, as you've described. The reason I think we shouldn't add it is because it doesn't feel "simple". Very few users will need this feature. And those who do may already need more than it can offer, such as wanting to set up multiple different rewrites. This seems like the kind of thing that could instead be a per-directory htaccess-like option.

@ethanaobrien
Copy link
Collaborator Author

That is probably true. Do you want me to add it to the htaccess file? this is kind of already implemented (with the htaccess request versioning feature) or should we just leave it?

@terreng
Copy link
Owner

terreng commented May 11, 2022

Let's leave it for now, and revisit it later.

@terreng terreng added the enhancement New feature or request label May 11, 2022
@hardduty
Copy link

online wan features update

@hardduty
Copy link

wan port sharing if port open router then internal lan ip or external lan ip convert method please demonstration one youtube video local level access okay wan level level access many problems

@terreng
Copy link
Owner

terreng commented Jan 27, 2023

@hardduty I don't understand what you're saying. Could you please open a new issue on GitHub? Could you please communicate more clearly?

@ethanaobrien
Copy link
Collaborator Author

I think he is asking how to make the website available on the internet and that he's having problems accessing it from another device on the same lan network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants