Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports to meet newer syntax and reduce filesize when bundling #15

Merged
merged 3 commits into from
Jul 26, 2018

Conversation

weskamm
Copy link
Contributor

@weskamm weskamm commented Jul 19, 2018

This removes (unused) lodash from package.json.
openlayers module has been replaced by ol and the syntax has been adapted.
Should result in smaller build sizes.

Copy link
Contributor

@KaiVolland KaiVolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Just one minor note regarding the version numbers of the packages in package.json.

This is somewhat of a high impact change. Or at least it could be.

We should consider to make a fresh release before merging this.

package.json Outdated
@@ -42,6 +41,9 @@
"@types/jest": "23.1.0",
"@types/node": "10.3.3",
"@types/ol": "4.6.2",
"babel-core": "^6.26.3",
"babel-jest": "^23.4.0",
"babel-preset-env": "^1.7.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all ^ occurences.

@chrismayer
Copy link
Contributor

Really nice @weskamm ! 👍

I agree with @KaiVolland that we should be careful with such a "big" change. At least a tag/release of the current state would be very helpful.

Copy link
Contributor

@KaiVolland KaiVolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I released a new version.
https://github.com/terrestris/geostyler-openlayers-parser/releases/tag/v0.6.0

Gonna merge this know and make a fresh release afterwards ...

@KaiVolland KaiVolland merged commit 0bd21b7 into geostyler:master Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants