Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DataProvider & ParserDesc #571

Closed
KaiVolland opened this issue Nov 12, 2018 · 3 comments
Closed

Refactor DataProvider & ParserDesc #571

KaiVolland opened this issue Nov 12, 2018 · 3 comments
Labels
enhancement New feature or request refactoring

Comments

@KaiVolland
Copy link
Collaborator

The DataParser should be modified to act more like the parsing of a Style.

Therfore we should make use of the DataParserConstructable interface from 'geostyler-style'.

@KaiVolland KaiVolland added enhancement New feature or request refactoring labels Nov 12, 2018
@KaiVolland KaiVolland added this to TODO in GeoStyler Main via automation Nov 12, 2018
@chrismayer
Copy link
Collaborator

The DataParser should be modified to act more like the parsing of a Style

Can you specify this a bit more, @KaiVolland? TIA!

@KaiVolland
Copy link
Collaborator Author

It's about choosing/setting the Parser in the DataProvider.

I think that we should make use of the DataParserConstructable in the DataProvider.
Almost like we do with the StyleParserConstructable in the StyleLoader.

This way the ParserDesc would become obsolete and the code would be less diverse.

@KaiVolland
Copy link
Collaborator Author

The DataParserConstructable and StyleParserConstructable have been removed so this issue is not relevant any more.

GeoStyler Main automation moved this from TODO to Done Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
No open projects
Development

No branches or pull requests

2 participants