Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ^ versions and readd lock file #98

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Use ^ versions and readd lock file #98

merged 2 commits into from
Jun 27, 2019

Conversation

hwbllmnn
Copy link
Contributor

@hwbllmnn hwbllmnn commented Jun 25, 2019 •
edited
Loading

@terrestris/devs Please review. Just downgrades canvas again to 2.0.0-alpha.1 due to compilation/test failures.

@hwbllmnn hwbllmnn changed the title WIP: Use ^ versions and readd lock file Use ^ versions and readd lock file Jun 27, 2019
dnlkoch
dnlkoch approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Please merge.

Not sure if it helps, but you may want to have a look at this PR for getting a hint on how to update to the latest canvas version.

@hwbllmnn
Copy link
Contributor Author

Unfortunately that didn't help, we're not even using mocking here (and adding jest-canvas-mock didn't help as well). Building the latest canvas from source also doesn't even work on a Debian jessie because the compiler/libstdc++ seems to be too new 😕

@hwbllmnn hwbllmnn merged commit 07e6a32 into geostyler:master Jun 27, 2019
@hwbllmnn hwbllmnn deleted the better-updates branch June 27, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnlkoch dnlkoch dnlkoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hwbllmnn @dnlkoch