-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more aliasing support #34
Conversation
e85afe8
to
94b7118
Compare
If people are able to test this without me having to do a release, I'd appreciate it. Am not finished but this branch currently should be in a working state. @snigel - This should fix your issues on #30. I reckon it can still be improved more, but it should do until then. |
@terrycain I had a quick look into the commit changes and looks great. I will get some time this week to test it and provide feedback regarding the Azure DNS and its per-record permissions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had time to look at the code portion, but the documentation looks okay to me.
If you want to give some external resources, these links could be helpful:
cf47380
to
7279fb7
Compare
7279fb7
to
4b87c0d
Compare
4b87c0d
to
9509574
Compare
9509574
to
114f629
Compare
114f629
to
f2105b5
Compare
An MR to fix a few things, will tag people to check over some stuff in a bit.