Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more aliasing support #34

Merged
merged 7 commits into from
May 16, 2023
Merged

Add more aliasing support #34

merged 7 commits into from
May 16, 2023

Conversation

terricain
Copy link
Owner

@terricain terricain commented Apr 7, 2023

An MR to fix a few things, will tag people to check over some stuff in a bit.

@terricain
Copy link
Owner Author

If people are able to test this without me having to do a release, I'd appreciate it. Am not finished but this branch currently should be in a working state.

@snigel - This should fix your issues on #30. I reckon it can still be improved more, but it should do until then.
@mdhowle - Have overhauled the DNS delegation docs section and added some more features, you mind having a read over it to see if it makes sense?
@theodiem - You mentioned in #20 about giving certbot only permissions to specific records and not deleting them during cleanup, this allows this somewhat. Currently you'll need to add an entry for each record you wish to not delete. If I can summon the will to redo how the config works, I might look into making this much nicer.

@theodiem
Copy link

@terrycain I had a quick look into the commit changes and looks great. I will get some time this week to test it and provide feedback regarding the Azure DNS and its per-record permissions.

Copy link
Contributor

@mdhowle mdhowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had time to look at the code portion, but the documentation looks okay to me.

If you want to give some external resources, these links could be helpful:

certbot_dns_azure/__init__.py Outdated Show resolved Hide resolved
certbot_dns_azure/__init__.py Outdated Show resolved Hide resolved
certbot_dns_azure/__init__.py Outdated Show resolved Hide resolved
@terricain terricain force-pushed the add_more_aliasing_support branch 2 times, most recently from cf47380 to 7279fb7 Compare May 16, 2023 19:38
@terricain terricain temporarily deployed to dev.azure May 16, 2023 19:38 — with GitHub Actions Inactive
@terricain terricain temporarily deployed to dev.azure May 16, 2023 19:41 — with GitHub Actions Inactive
@terricain terricain temporarily deployed to dev.azure May 16, 2023 19:45 — with GitHub Actions Inactive
@terricain terricain temporarily deployed to dev.azure May 16, 2023 20:05 — with GitHub Actions Inactive
@terricain terricain temporarily deployed to dev.azure May 16, 2023 20:17 — with GitHub Actions Inactive
@terricain terricain merged commit c1d8492 into master May 16, 2023
3 checks passed
@terricain terricain deleted the add_more_aliasing_support branch May 16, 2023 20:20
@terricain
Copy link
Owner Author

@snigel @mdhowle @theodiem These changes are now out on 2.2.0b0 on PyPI and on the snap edge channel. Assuming I get no complaints, I'll release 2.2.0 officially in a week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants