Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing EC2 auth support #61

Closed
TerryHowe opened this issue Apr 25, 2018 · 6 comments
Closed

Missing EC2 auth support #61

TerryHowe opened this issue Apr 25, 2018 · 6 comments

Comments

@TerryHowe
Copy link
Owner

No description provided.

@ghost
Copy link

ghost commented Oct 11, 2018

I would like to tackle this issue but not sure how I could write any automated functional tests for it. I can test this manually but wouldn't be able to include any tests in the CI part due to the AWS requirements.

I wondered if there is anyway we could use the python mocking libraries in anyway?

Any suggestions?

@TerryHowe
Copy link
Owner Author

I think it will be too much effort to write an automated functional test for this.

@ghost
Copy link

ghost commented Oct 11, 2018

That's fair enough.

Many thanks

@ghost
Copy link

ghost commented Oct 16, 2018

Hey @TerryHowe

I have made a small start on the IAM auth. The methods work but I don't seem to get the token within the client object. I know 100% a token is being returned but for some reason its not ending up in the client object passed into the "hashivault_auth" method. I just get a empty token value.

Its late in the UK so I might just be missing something silly but wondered if you get a moment to have a quick look.

Hear is the branch
https://github.com/simonmacklin/ansible-modules-hashivault/tree/feature-support_iam_role
https://github.com/simonmacklin/ansible-modules-hashivault/commit/05005712aafeaba8b79833ef473fcbcb5e52289a

@ghost
Copy link

ghost commented Oct 17, 2018

Hi @TerryHowe

I have figured it out. It was just late :)

@TerryHowe
Copy link
Owner Author

I think we are done with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant