Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support consistent undo behavior #22

Closed
terryma opened this issue Apr 17, 2013 · 1 comment
Closed

[Feature] Support consistent undo behavior #22

terryma opened this issue Apr 17, 2013 · 1 comment

Comments

@terryma
Copy link
Owner

terryma commented Apr 17, 2013

Currently the plugin's undo behavior is unpredictable, both inside and outside of multicursor mode. For example, text inserted into the buffer during multicursor mode is undone one character at a time in all virtual cursor locations. The correct behavior should be consistent with Vim - everything entered during insert mode before exiting back to normal mode is 1 undo block.

Implementing this might require some clever hackery with using undojoin, further investigation is needed.

@d11wtq
Copy link

d11wtq commented Apr 25, 2013

I can confirm that this now behaves much more sanely. I did just manage to get it to do something odd, but I can't reproduce it now, as I'm not sure what I did. It undid everything I inserted as a single batch, but the file-modified status was showing 59 changes. Pressing u 59 times made Vim agree there were no changes, but nothing was actually being changed at all. I can live with that though... I was mashing keys right before it trying to make #28 break (happy to say unsuccessfully).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants