Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Pass arguments to Program" not retaining checkbox check #19

Closed
stringfieldmark opened this issue Jun 6, 2021 · 7 comments
Closed

"Pass arguments to Program" not retaining checkbox check #19

stringfieldmark opened this issue Jun 6, 2021 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@stringfieldmark
Copy link

Describe the bug
When checking the checkbox for "Pass arguments to Program" and entering an argument, the checkbox does not retain the check, therefore the argument does not get passed to the program. I have also just done a clean install on another PC that has never had DM installed and it exhibits the same behaviour.

To Reproduce
Steps to reproduce the behaviour:

  1. Open DisplayMagician
  2. Click on 'Game Shortcuts'
  3. Select game shortcut to edit
  4. Click 'Edit'
  5. Select the 'Choose what happens before' tab
  6. Enable the 'Checkbox' next to 'Pass arguments to program:'
  7. Enter an argument (i.e. -switchgame iRacing)
  8. Click 'Save'
  9. Reselect the game shortcut just edited
  10. Click 'Edit'
  11. Select the 'Choose what happens before' tab

Expected behaviour
'Checkbox' next to 'Pass arguments to program:' should now be checked (enabled) but it is not

Screenshots
N/A (I can do a video if needed)

Reporting Logs
N/A - if required let me know and I'll get the logs attached

Enviroment (please complete the following information):

  • Windows Version: 21H1 (OS Build 19043.1023)
  • DisplayMagician Version: 1.1.2.0
  • Video Card: Asus NVIDIA GTX1080Ti OC
  • Number and make/model of monitors: 3xMSI MAG322CQR and 1xBenQ PD3200U (running at 1440)
  • Date of last video driver update: 2021-06-03 (466.63)
  • Date of last windows update: 2021-05

Additional context
This is the first time I am using the arguments feature so am not sure if this worked before in older versions

@stringfieldmark stringfieldmark added the bug Something isn't working label Jun 6, 2021
@terrymacdonald
Copy link
Owner

Gah, I thought I tested all the bits of the start program stuff :(. Very sorry to all. Looks like I'll need a new release.

@terrymacdonald terrymacdonald added this to the 1.1.3 milestone Jun 6, 2021
@terrymacdonald
Copy link
Owner

@stringfieldmark Can you please upgrade your DisplayMagician to v1.1.3 and try again. I found I'd missed two simple assignments within the code :/. Took me 10 seconds to fix....

I'm planning on adding some unit tests to the app eventually to alleviate some of these errors, but I want to wait and do it as part of the move from .NET Framework 4.8 to .NET6 and MAUI. Hopefully the big functional changes are all completed now, and it will be just little features and enhancements to add.

Anyway - please report back here as to whether this issue is now fixed.

@stringfieldmark
Copy link
Author

Hi Terry,

The arguments now work, however, I cannot see any icons in the game shortcut library.

1.1.2.0:
Version - 1 1 2 0

1.1.3.0
Version - 1 1 3 0

I had to create a new shortcut to check the arguments and saved it to the desktop fine, but the app library shows up as blank.

@terrymacdonald
Copy link
Owner

terrymacdonald commented Jun 7, 2021 via email

@terrymacdonald
Copy link
Owner

@stringfieldmark Just letting you know I've fixed the issue. It was another stupid bug where the resiliency changes I made to ignore unsupported game libraries also inadvertently also filtered out application-based game shortcuts :/.

Now fixed in v1.1.4. Hopefully this is the last problem for a while as so many silly errors on my part means everyone has to keep applying updates (and that gets frustrating as a user). Really sorry that my missing these errors is causing you so much testing effort.

Thanks for helping me out by reporting all these issues so I can straighten them out. It really helps.

Thanks
Terry

@terrymacdonald terrymacdonald removed this from the 1.1.3 milestone Jun 7, 2021
@stringfieldmark
Copy link
Author

Hey Terry,

1.1.4 has worked a treat. So far so Gr8!

This is now, for me anyway, the ultimate start-up sequence program and not only for my gaming. I can see myself using this as a sequence for starting up what I need for my workday every morning.

Oh, and I am more than happy to do any testing, it is no effort at all and I've not found this frustrating at all. The effort you are putting into this is for us (the users), we should have no complaints.

Keep up the gr8 work.

Mark

@terrymacdonald
Copy link
Owner

terrymacdonald commented Jun 8, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants