Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected top_retain/reduce_vars/unused results #161

Closed
opichals opened this issue Nov 6, 2018 · 2 comments · Fixed by #162
Closed

Unexpected top_retain/reduce_vars/unused results #161

opichals opened this issue Nov 6, 2018 · 2 comments · Fixed by #162

Comments

@opichals
Copy link

opichals commented Nov 6, 2018

Bug report or Feature request?

Bug report

Version (complete output of terser -V)

3.10.11

Complete CLI command or minify() options used

See the failing test commit.

When the top_retain function is called twice the output is fine but when it is only called once then the output is not what one would expect.
@kzc kzc mentioned this issue Nov 6, 2018
Merged
@kzc
Copy link
Contributor

kzc commented Nov 6, 2018

Please test against #162 and report your findings.

@opichals
Copy link
Author

opichals commented Nov 6, 2018

@kzc Thank you! Confirmed, the #162 fixes this issue.

opichals added a commit to opichals/rollup-plugin-espruino-modules that referenced this issue Nov 25, 2018
@opichals
fix: upgrade terser to avoid doubling onInit problem
128409b 
Contains terser/terser#161 fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

have reduce_vars and inline respect top_retain
2 participants
@opichals @kzc