Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters should run through array and leverage thread #221

Merged
merged 1 commit into from Oct 20, 2022

Conversation

wsargent
Copy link
Collaborator

@wsargent wsargent commented Oct 20, 2022

Make Filters a public class, allow an array of classloaders to be passed in, finally default to the thread's context class loader.

This is because sbt does some fancy in process class loading and so just relying on the app class loader is insufficient.

https://www.scala-sbt.org/1.x/docs/In-Process-Classloaders.html

@wsargent wsargent merged commit 893a5c9 into tersesystems:main Oct 20, 2022
@wsargent wsargent deleted the filter-classloader branch October 20, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant