Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional JWT algorithm support #77

Closed
wSedlacek opened this issue Sep 14, 2022 · 2 comments · Fixed by #80
Closed

Additional JWT algorithm support #77

wSedlacek opened this issue Sep 14, 2022 · 2 comments · Fixed by #80
Labels
non-breaking

Comments

@wSedlacek
Copy link

It would be great to support additional algorithms as changing them out in production can be difficult if you have a lot of consumers of the public keys.

Specifically supporting the ones from this list: HS384, HS512, RS384, RS512, ES256, ES384 and ES512
JoshMcCullough added a commit that referenced this issue Nov 8, 2022
@JoshMcCullough
add support for higher-bit HS/RS algorithms
dd3ef43 
fixes #77
@JoshMcCullough JoshMcCullough mentioned this issue Nov 8, 2022
Merged
@JoshMcCullough
Copy link
Contributor

JoshMcCullough commented Nov 8, 2022 •
edited
Loading

In the PR linked above, I added support for the other HS* and RS* algorithms. I didn't add ES* support as we don't currently support any of those algorithms so that might be a bit more work. If ES* support is truly important, please feel free to open another ticket and we'll take a look in the future (or welcome a PR for it).

JoshMcCullough added a commit that referenced this issue Nov 9, 2022
@JoshMcCullough
add support for higher-bit HS/RS algorithms
b59a839 
fixes #77
JoshMcCullough added a commit that referenced this issue Nov 9, 2022
@JoshMcCullough
add support for higher-bit HS/RS algorithms (#80)
d7c3cb4 
* add support for higher-bit HS/RS algorithms
fixes #77

* add Git hooks

* use variable for Docker image name

* cleanup
@JoshMcCullough
Copy link
Contributor

@wSedlacek the PR's been merged, so you can now use the higher-bit HS* and RS* alhorithms.

@JoshMcCullough JoshMcCullough mentioned this issue Nov 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
non-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add support for higher-bit HS/RS algorithms TeslaGov/ngx-http-auth-jwt-module
2 participants
@JoshMcCullough @wSedlacek