Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base_url is not used by the Web App eg. in the navbar #2056

Closed
1 task done
metaben opened this issue Oct 13, 2021 · 2 comments
Closed
1 task done

base_url is not used by the Web App eg. in the navbar #2056

metaben opened this issue Oct 13, 2021 · 2 comments
Labels
closed:duplicate This issue or pull request already exists

Comments

@metaben
Copy link

metaben commented Oct 13, 2021

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

I deployed TeslaMate to https://my.example.com/foo/bar and configured base_url and grafana_url, but noticed that internal navigation of the Web App was 404ing. It seems that the setting for base_url is not used by the Web App, even though it is being used (correctly) for the dashboards that link back from Grafana.

Expected Behavior

The Web App's internal links should use base_url. There should be consistent behaviour wrt the use of grafana_url and base_url in the navbar.

Steps To Reproduce

  1. go to settings
  2. set base_url to https://my.example.com/foo/bar
  3. restart containers
  4. go to navbar and select Charges from Dashboards menu
  5. looking at the Charges dashboard, mouseover a location and the URL will be https://my.example.com/foo/bar/geo-fences/new[...]
  6. go to the TeslaMate Web App and mouseover Settings in the nav bar; note that the URL is to /geo-fences but not /foo/bar/geo-fences.

Relevant log output

[13/Oct/2021:12:51:00 +0000] "GET /settings HTTP/2.0" 404 19 "-" "-" 132 "-" "-" 0ms

[13/Oct/2021:12:53:34 +0000] "GET /geo-fences HTTP/2.0" 404 19 "-" "-" 138 "-" "-" 0ms

Screenshots

No response

Additional data

No response

Type of installation

Docker

Version

v1.24.2

@adriankumpf adriankumpf added the closed:duplicate This issue or pull request already exists label Oct 15, 2021
@adriankumpf
Copy link
Collaborator

Duplicate of #1902. The settings for the Web App URL is only intended to allow links from Grafana to the TeslaMate UI.

@metaben
Copy link
Author

metaben commented Oct 16, 2021

then you've implemented base_url as return_from_grafana_url 🙄 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants