ssh-keygen relies on a binary

[tcr]

Turns out it was really hard to find a ssh-keygen binary on Windows. It's in Git Bash, but not in chocolately or made available to Powershell or Bash.

[johnnyman727]

This is a bit of a duplication of one of the checkboxes in #64.

[tcr]

Oh interesting. I suppose splitting it out gives it more visibility as an easy task.

[johnnyman727]

+1

[LinusU]

Anyone with windows that could test this patch? 👷

ericvicenti/ssh-keygen#5

[tcr]

Update: @LinusU's patch works but has been blocked by this issue: nodejs/node-v0.x-archive#4051

Since Windows exporting OpenSSL labels is unlikely to happen, and this is a minor system component, I think the addition of more binary dependencies isn't necessary. Instead, I'm proposing we merge #429 which adds support for a pure-JS keygen.

[Frijol]

@tcr #429 is now merged, is this resolved?

If so, is #64 also resolved?

[johnnyman727]

Yep, we're all good!