Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t2 update: autocheck for out of date firmware with each cli usage #257

Open
johnnyman727 opened this issue Aug 21, 2015 · 8 comments
Open

Comments

@johnnyman727
Copy link
Contributor

With the Tessel 1 CLI, we would check if the CLI or firmware was out of date each time any command was run. This helped users know right away when an update was available rather than running it only when they run into problems.

@wprater
Copy link
Member

wprater commented Sep 18, 2015

maybe add a ~/.tessel/update_check with a datestamp as well, so it does not check every time.

@rwaldron
Copy link
Contributor

I don't think this should be done on every command. It would be more reasonable to:

  • check when the Tessel is powered on and gets a LAN connection
  • check when the user actually requests a check

@wprater
Copy link
Member

wprater commented Sep 18, 2015

I like the idea of showing the user when a new version is available, as other CLI tools do. And agree that it should not be every command, which is why I suggested a date stamp file to ensure it's only called once per day (for example).

or are you advocating you can only check for a new version be t2 update -l etc?

@LinusU
Copy link
Contributor

LinusU commented Sep 18, 2015

There is a package on npm which many cli tool uses which actually fires away the update check in a background thread and is very smart on how it does things. Give me a minute...

@LinusU
Copy link
Contributor

LinusU commented Sep 19, 2015

Here we go! 🎢

https://github.com/yeoman/update-notifier

@johnnyman727
Copy link
Contributor Author

Ah yes! That node module would be perfect. It's super handy to be notified when some component of the system is out of date.

@johnnyman727
Copy link
Contributor Author

This is still a useful feature for anyone interested in contributing. The fix would entail adding a "minCLI" and "maxCLI" to each property of the builds.json file living on AWS (someone from the Tessel Team Members can give you access), then making use the package linked up to ensure the version of firmware on the Tessel (can be returned with tessel.version) and the CLI are compatible.

@Frijol
Copy link
Member

Frijol commented Mar 26, 2017

Revisiting this issue, it looks like discussion was around update notifications for both CLI and firmware.

  • t2-cli notifies users of updates using the yeoman update notifier, but
  • t2-firmware does not yet have an update notifier.

@johnnyman727 I'm trying to understand your proposed solution. It seems to have more to do with compatibility between CLI version and firmware version than to do with whether your firmware is up to date. Is that correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants