Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to de-authenticate people from a given Tessel #90

Closed
Frijol opened this issue May 4, 2015 · 12 comments
Closed

Need a way to de-authenticate people from a given Tessel #90

Frijol opened this issue May 4, 2015 · 12 comments

Comments

@Frijol
Copy link
Member

Frijol commented May 4, 2015

Currently we have tessel provision to authenticate, but there's no way to see who is authenticated or remove them.

@johnnyman727
Copy link
Contributor

How about a --remove flag for the authorize command? I think that's better than a whole new command because I think it won't be used all that often.

@Frijol
Copy link
Member Author

Frijol commented May 5, 2015

and --list. That makes sense

@johnnyman727
Copy link
Contributor

I'm not sure if we can actually show who is authenticated beyond just printing out a key. What did you have in mind @Frijol ?

@Frijol
Copy link
Member Author

Frijol commented May 5, 2015

not sure. ssh-keygen appends an email, doesn't it?

@nplus11
Copy link
Contributor

nplus11 commented May 5, 2015

Yes, it would be able to display the email/name at the end of the key. This might be too revealing, but it would show the various devices. Keep in mind those ending emails can also be things like johndoe@Johns-MacBook.local

@johnnyman727
Copy link
Contributor

That sounds good to me. @Frijol is this addition ready to be moved over to the provision issue?

@Frijol
Copy link
Member Author

Frijol commented May 6, 2015

What is the interplay between this and the new tessel key command?

@johnnyman727
Copy link
Contributor

tessel provision --remove would internally call the same function as tessel key delete.

@Frijol
Copy link
Member Author

Frijol commented May 6, 2015

Sounds good. To fully spec this, we should have an example of the features: --list and --remove

@kevinmehall
Copy link
Member

No, it's not the same as tessel key delete as specified in #99 -- key delete would remove the keypair locally (why?), while provision --remove would remove the public key from a device. We should also consider the case of removing someone else's key, rather than your own.

@johnnyman727
Copy link
Contributor

No, it's not the same as tessel key delete as specified in #99 -- key delete would remove the keypair locally (why?), while provision --remove would remove the public key from a device.

Yeah, my mistake - @kevinmehall's right.

We should also consider the case of removing someone else's key, rather than your own.

For this case, we can make the API remove your key by default or allow a --email flag for the user you would like to deauthenticate.

@johnnyman727
Copy link
Contributor

I added this as a to-do item in #64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants