Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete quoting for parameters in "configure.ac" #100

Closed
elfring opened this issue Sep 16, 2015 · 3 comments
Closed

Complete quoting for parameters in "configure.ac" #100

elfring opened this issue Sep 16, 2015 · 3 comments

Comments

@elfring
Copy link

elfring commented Sep 16, 2015

I suggest to be more explicit where macro expansion will not be required in the current build configuration script.

@zdenop zdenop closed this as completed Mar 4, 2016
@zdenop zdenop reopened this Mar 4, 2016
@zdenop
Copy link
Contributor

zdenop commented Mar 6, 2016

Please make a pull request or send the patch.

@amitdo
Copy link
Collaborator

amitdo commented May 27, 2016

@stweil
Do you think we need to fix something in the current configure.ac as suggested here? If the answer is 'yes', please send a PR.

@stweil
Copy link
Contributor

stweil commented May 27, 2016

PR #335 should fix this issue. I tested my patch like this:

# Save old configure.
mv configure old-configure
# Apply my patch.
...
# Create new configure.
autoconf
# Compare old and new configure. There should be only whitespace changes.
diff -u --ignore-space-change old-configure configure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants