Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved identifier violation #96

Closed
elfring opened this issue Sep 16, 2015 · 3 comments
Closed

reserved identifier violation #96

elfring opened this issue Sep 16, 2015 · 3 comments

Comments

@elfring
Copy link

elfring commented Sep 16, 2015

I would like to point out that identifiers like "TESSERACT_API_BASEAPI_H__" and "TESSERACT_CCUTIL_PLATFORM_H__" do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

@zdenop
Copy link
Contributor

zdenop commented Mar 15, 2016

Yes, you can make a pull request.

@zdenop
Copy link
Contributor

zdenop commented Mar 15, 2016

I did one more check with google cpplint:
it ask to use API_BASEAPI_H_, while your doc suggest to use API_BASEAPI_H...
I think we should fit to google-style (and there should be more style fixes)

@amitdo
Copy link
Collaborator

amitdo commented Mar 28, 2016

According to their C++ Style Guide it should be: TESSERACT_API_BASEAPI_H_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants