Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: #pragma omp simd (don't merge) #983

Closed
wants to merge 2 commits into from

Conversation

rfschtkt
Copy link
Contributor

@rfschtkt rfschtkt commented Jun 7, 2017

If OpenMP 4.0 is available, use it for vectorisation.

Now how should I test this, I wonder...

@zdenop
Copy link
Contributor

zdenop commented Oct 13, 2018

Just remark: Visual studio 2015 support only OpenMP 2.0 standard. For VS 2017 there is not even documentation page for it :-(
Community request for new standard was declined.

@zdenop zdenop added this to the 4.1.0 milestone Oct 13, 2018
@amitdo
Copy link
Collaborator

amitdo commented Oct 13, 2018

@zdenop
Copy link
Contributor

zdenop commented Oct 14, 2018

@amitdo: thanks. I misunderstand link - I was expecting that there would be option to select version 2017 in combo "Other version". I tried to search on docs.microsoft.com but nothing usefull found there.

Anyway result is still the same:

Visual C++ supports the OpenMP 2.0 standard.

@amitdo
Copy link
Collaborator

amitdo commented Oct 14, 2018

@zdenop

Visual C++ supports the OpenMP 2.0 standard.

From #954:

amitdo commented on Jun 6, 2017

Just a note: #pragma omp simd is not supported with MSVC.

rfschtkt commented on Jun 6, 2017

@amitdo I don't think that the laggard should set the pace, considering how relatively easy the pragma is to use.

:-)

@amitdo
Copy link
Collaborator

amitdo commented Mar 16, 2019

@zdenop
Copy link
Contributor

zdenop commented Jul 13, 2019

@stweil : what about this? Even we do not suggest to use openmp, I think this could be merged for future development/test. Recent version of our most common compilers support it:

  • From GCC 4.9.1, OpenMP 4.0 is fully supported
  • OpenMP 4.5 has been available since Clang 3.9
  • VS 2019 should support #pragma omp simd

@zdenop
Copy link
Contributor

zdenop commented Jul 27, 2019

Closing this PR because function WeightMatrix::DotProduct was removed and WeightMatrix::MatrixDotVector rewritten.

@zdenop zdenop closed this Jul 27, 2019
@amitdo amitdo added the SIMD label Feb 27, 2021
@amitdo amitdo added the RFC label Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants