Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that UPnP resource properties included size #2584

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

tesshucom
Copy link
Owner

Related : #2541

Problem description

Due to a flaw during UPnP migration in v114.0.0, the size was incorrectly included in the UPnP resource properties. There are currently no UPnP Players that are known to cause playback problems.

  • If transcoding is used to perform compression in UPnP, some UPnP Players may incorrectly display the original file size. This is a bug. It's server-side view problems.
  • It's up to the Client, but some Players may display the playing time incorrectly. If anything, it's a bug in the Client.

Steps to reproduce

  1. Enable Mp3 etc. on the UPnP settings page (UPnP transcoding is disabled by default)
  2. With UPnP client, check the file size of files in formats that may experience size compression, such as FLAC

System information

  • Jpsonic version: v114.0.0
  • Client: UPnP only

Additional notes

  • It's not serious so it will be released as a hotfix for a minor version
  • Currently, the expected behavior is not to notify the file size. If VBR streaming is improved in the future, these specifications may change.

@tesshucom tesshucom added in: UPnP Issues in UPnP type: hotfix Should be in patch release instead of next version release type: degraded Degraded existing functionality labels Feb 13, 2024
@tesshucom tesshucom added this to the jpsonic 114.1 milestone Feb 13, 2024
@tesshucom tesshucom self-assigned this Feb 13, 2024
@tesshucom tesshucom merged commit ecc4756 into hotfix Feb 13, 2024
3 checks passed
@tesshucom tesshucom deleted the fix-upnp-file-size branch February 13, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: UPnP Issues in UPnP type: degraded Degraded existing functionality type: hotfix Should be in patch release instead of next version release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant