-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate UPnP menu to customizable #2615
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tesshucom
force-pushed
the
feature/upnp-menu-customize
branch
2 times, most recently
from
April 13, 2024 05:49
574170f
to
92546b8
Compare
tesshucom
commented
Apr 13, 2024
jpsonic-main/src/main/java/com/tesshu/jpsonic/service/upnp/processor/ProcId.java
Outdated
Show resolved
Hide resolved
- Previously, the UPnP Top menu consisted of Property file settings. This will be changed so that it can be generated dynamically from the DB definition. - The concept of hierarchy will be introduced to the UPnP top menu. - This commit only includes UPnP View Changes. The edit of menu is independent of these implementations and will be realized as a DB data edit from the Web page.
This commit will only add edits to existing UPnP views. Customization features for these higher-level menu items will be added in a later commit. - Enable/disable existing UPnP View - Add feature to rename existing UPnP views
- So-called Top Menu settings
- The menu order and the default value of enabled have been redefined. - If all submenus are disabled, the default submenu will be enabled.
- These have been changed to be managed on the database.
tesshucom
force-pushed
the
feature/upnp-menu-customize
branch
from
April 13, 2024 09:23
ec227b1
to
80a518a
Compare
This was referenced Apr 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites: #2587
Overview
Users will have the ability to customize their UPnP content list more flexibly.
Jpsonic's UPnP has long been a style that provides multiple views with slightly different specifications, and allows the user to enable the one of them that they want to use. This pull request will allow users to rename and reorder UPnP items.
Goal
Non-Goal
Web page changes
UPnP settings Page has been changed
"UPnP basic settings" remains unchanged. Newly added "Menu settings" and "Customizing content display".
Menu settings
Currently, there are eight basic menu items such as FOLDER and ARTIST. New items are planned to be added to these menu items in v114.x.
Settings can be changed instantly. No service restart is required. With software such as BubbleUPnP, which has an excellent cache refresh design, it will be easy to confirm this.
Customizing content display
Contents of changes