-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slicing shall be blocked #205
Comments
Hi Son,
So, please create an error message in case you find a slicing operator or a negative index (e.g. Positive operator Thank you, |
Self test: added JPP_1350 - JPP_1364 (topic: slicing; tests commented out) |
Hello Holger, Hello Thomas, I created the commit 48eae0f0df on stabi branch. I aslo enabled the 2 test cases JPP_1350 - JPP_1364 Thank you, |
Hi Son, in one of my commits I wrote: "JPP_1350 - JPP_1364". And the meaning of this is: "from JPP_1350 to JPP_1364", and not: "JPP_1350 and JPP_1364". All further test cases between 1650 and 1364 are still commented out - and cause errors when I activate them. But to fix the remaining aspects is for 0.12.x. |
Example:
Expected: Slicing is not supported
still causes
|
Hello Holger, All blocked slicing's test cases are uncovered and tested successful. Thank you, |
Hi Son, please keep in mind that there is at least one error message active that mentions the possibility to use slices:
That is misleading for the audience, because slicing shall be blocked. In this case you cannot take over the error message from Python. |
Hello Holger, Could you please check error message again, I updated error message as Thomas' suggestion: #186 (comment) Thank you, |
Hi Son, I still get this error message with slicing proposed:
But " |
Hello Holger, I updated error message in this case. Thank you, |
Retest successful. Issue can be closed. |
Released with RobotFramework AIO 0.12.0 |
Hi Thomas,
based on one of our latest discussions, my understanding now is that slicing shall not be supported (even in case of it's already working partially).
Therefore possibly ongoing development should be stopped.
And slicing notation inside square brackets has to cause a corresponding error message.
Reference:
#184 (comment)
The text was updated successfully, but these errors were encountered: