feat: Tell the user when we can't remove the image if it's in use #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damacus
force-pushed
the
image-in-use-fix
branch
from
018b983
to
6a1061a
Compare
3 tasks
xorima
approved these changes
Nov 16, 2023
|
waiting for #410 |
xorima
previously approved these changes
Nov 26, 2023
damacus
force-pushed
the
image-in-use-fix
branch
from
6a1061a
to
3c4da7d
Compare
Signed-off-by: Dan Webb <dan.webb@damacus.io> Co-authored-by: Edward Smith <edward@ersmith.me> Signed-off-by: Dan Webb <dan.webb@damacus.io>
damacus
force-pushed
the
image-in-use-fix
branch
from
3c4da7d
to
fa4898a
Compare
damacus
changed the title
|
@ersmith thanks very much for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe what this change achieves
Issues Resolved
List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant
Type of Change
Our release process assumes you are using Conventional Commit messages.
The most important prefixes you should have in mind are:
_fix_: which represents bug fixes, and correlates to a SemVer patch._feat_: which represents a new feature, and correlates to a SemVer minor._feat!_:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a major version change.If you have not included a conventional commit message this can be fixed on merge.
Check List