Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows AMIs that don't have word 'windows' in image.name result in undefined methodversion' for nil:NilClass #322

Closed
vinyar opened this issue Jun 22, 2017 · 3 comments · Fixed by #387

Comments

@vinyar
Copy link

vinyar commented Jun 22, 2017

The Windows2016 AMI we're using does not contain the word 'windows' in the AMI name.
This results in an error: [undefined method version' for nil:NilClass`

The error seems to come from this code:
https://github.com/test-kitchen/kitchen-ec2/blob/master/lib/kitchen/driver/aws/standard_platform/windows.rb#L54

Full debug gist:
https://gist.github.com/mbenachour/005aa718b8abb2978d9f6cb01e2f0644

@mbenachour

@vinyar vinyar changed the title actual_platform does not seem to work with Windows AMIs that don't have word 'windows' in image.name Windows AMIs that don't have word 'windows' in image.name result in undefined methodversion' for nil:NilClass Jun 22, 2017
@vinyar
Copy link
Author

vinyar commented Jun 22, 2017

We've cloned the AMI and renamed it to contain 'windows' in the AMI name and that got us moving forward.

@BenLiyanage
Copy link

Just posted a PR that fixes this issue--if you can still reproduce this do you mind testing out my branch?

@jclynny
Copy link

jclynny commented Feb 9, 2018

Would love to see some traction on this, have been battling this for a bit, now I've put in the suggested workaround to have 'windows' in the AMI name, but I'd really like to see this work as it has in prior platform versions, and Linux, I don't believe I've ever had to specify the platform name in the AMI Name prior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants