Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implements placement options and license specifications #615

Merged
merged 10 commits into from
Nov 28, 2023

Conversation

mfortin
Copy link
Contributor

@mfortin mfortin commented Nov 27, 2023

Description

Implements placement options and license specifications

Issues Resolved

#591
tenancy: dedicated may not be sufficient for all use cases. Adding options to set placement host resource group arn and license configurations may be required in some advanced use cases.

Type of Change

feat: Add placement options and License Specifications

Check List

@mfortin
Copy link
Contributor Author

mfortin commented Nov 27, 2023

@damacus fixed the code

@damacus
Copy link
Contributor

damacus commented Nov 27, 2023

Looks like we've got a small diff in the test now. Which is probably expected?

       @@ -2,9 +2,10 @@
        :image_id => nil,
        :instance_type => nil,
        :key_name => nil,
       +:licenses => [{:license_configuration_arn=>"arn:aws:ec2:us-east-1:123456789012:license-configuration/my-license"}],
        :max_count => 1,
        :min_count => 1,
       -:placement => {:availability_zone=>"eu-east-1c", :tenancy=>"dedicated"},
       +:placement => {:host_resource_group_arn=>"arn:aws:ec2:us-east-1:123456789012:resource-group/my-group"},
        :private_ip_address => nil,
        :subnet_id => nil,
     # ./spec/kitchen/driver/aws/instance_generator_spec.rb:694:in `block (5 levels) in <top (required)>'

@damacus damacus merged commit 10f0232 into test-kitchen:main Nov 28, 2023
5 checks passed
@damacus
Copy link
Contributor

damacus commented Nov 28, 2023

Thanks!

@mfortin mfortin deleted the issue-591 branch November 30, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants