Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate checksum of downloaded image #1

Open
ahnl opened this issue Aug 9, 2021 · 5 comments
Open

Validate checksum of downloaded image #1

ahnl opened this issue Aug 9, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@ahnl
Copy link
Member

ahnl commented Aug 9, 2021

YTL is adding sha256 checksums for the images.

They are implementing checksum validation to Naksu (digabi/naksu#57), see their PR for their implementation.

@developerfromjokela
Copy link
Member

Hmm, doesn't etcher have hash validation?

@ahnl
Copy link
Member Author

ahnl commented Aug 9, 2021 via email

@developerfromjokela developerfromjokela added the 🤔 Needs more thinking before we get into action label Aug 9, 2021
@developerfromjokela
Copy link
Member

Seems like hash exists only for server image.

I feel no reason to validate any hashes (besides etcher's existing mechanism) if client image doesn't have them.

When they'll provide the hash, we can think about it. For now, notfix.

@developerfromjokela developerfromjokela added wontfix This will not be worked on and removed 🤔 Needs more thinking before we get into action labels Aug 22, 2021
@developerfromjokela developerfromjokela added enhancement New feature or request and removed wontfix This will not be worked on labels Oct 15, 2021
@developerfromjokela
Copy link
Member

With new update, there seems to be a hash for student version of exam. Would consider implementing.

@Esinko
Copy link
Member

Esinko commented Oct 15, 2021

Implementing this feature is a good idea. Though validation of images should happen once after the download.

developerfromjokela pushed a commit that referenced this issue Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants