Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/auth/changepassword doesn't require secure access token #98

Open
Eldemarkki opened this issue Nov 25, 2023 · 0 comments
Open

/auth/changepassword doesn't require secure access token #98

Eldemarkki opened this issue Nov 25, 2023 · 0 comments

Comments

@Eldemarkki
Copy link
Member

Eldemarkki commented Nov 25, 2023

The API specification says that the /auth/changepassword endpoint requires a secured access token but in reality it doesn't. We should either remove the requirement from the API documentation, or change the logic to require it.

I'd recommend just removing it from the API docs and keeping the implementation as is, because the endpoint requires the same values as the secure access token generation endpoint, so requiring SAT for changing password doesn't really provide any benefits.

@Eldemarkki Eldemarkki changed the title /auth/changepassword doesn't require secure access /auth/changepassword doesn't require secure access token Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant