modulegen: generate code-workspace with json marshal #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
previously approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Hi @mmorel-35 I went ahead and pushed a commit simply adding the new file to the module docs: 6e4d7f7
I think this PR LGTM! Thanks again!
|
I still need to get used to seeing the core module at the bottom, but I like the improvement. I guess you forced the commit of the workspace file, right? Oh wait, it could be my own setup, which ignores the |
|
Probably something like that as the .gitignore doesn’t say anything about .vscode. |
mmorel-35
commented
Aug 30, 2023
mdelapenya
previously approved these changes
Aug 30, 2023
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Co-Authored-By: Manuel de la Peña <social.mdelapenya@gmail.com>
|
SonarCloud Quality Gate failed.
|
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Aug 30, 2023
* main: (32 commits) fix: remove wrong example from workspace (testcontainers#1556) chore(deps): bump the all group in /modules/localstack with 1 update (testcontainers#1552) modulegen: generate code-workspace with json marshal (testcontainers#1551) chore(deps): bump the all group in /modules/compose with 2 updates (testcontainers#1553) feat: add mariadb module (testcontainers#1548) feat(modulegen): print out VSCode workspace file if needed (testcontainers#1549) modulegen: generate md file inside internal/mkdocs (testcontainers#1543) modulegen: create internal/module and internal/modfile (testcontainers#1539) [Enhancement]: add ability to set repo:tag for ContainerRequest FromDockerfile (testcontainers#1508) Fix module generator for examples (testcontainers#1545) Update pulsar.md (testcontainers#1542) modulegen: create internal/make (testcontainers#1537) chore: fix workflow (testcontainers#1538) chore(deps): bump the all group in /examples/cockroachdb with 1 update (testcontainers#1522) chore(deps): bump the all group in /examples/bigtable with 1 update (testcontainers#1534) chore(deps): bump the all group in /modules/localstack with 4 updates (testcontainers#1535) chore(deps): bump the all group in /modules/k3s with 2 updates (testcontainers#1526) chore(deps): bump the all group in /examples/spanner with 2 updates (testcontainers#1532) chore(deps): bump the all group in /examples/firestore with 1 update (testcontainers#1523) chore(deps): bump the all group in /modules/redis with 1 update (testcontainers#1524) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the template with the marshalling of a Config Object.
The path can be relative so it is relative to the .vs-code folder. As it is platform independant, it can be shared in the project.
Why is it important?
This allows to define multi-root-workspaces in VSCode.
Related issues
I tried it on windows plateform. @mdelapenya if you do have another platform, can you confirm, this works ?