Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add MSSQLServer module #1789

Closed
agosmou opened this issue Oct 23, 2023 · 6 comments · Fixed by #1969
Closed

[Feature]: Add MSSQLServer module #1789

agosmou opened this issue Oct 23, 2023 · 6 comments · Fixed by #1969
Labels
feature New functionality or new behaviors on the existing one

Comments

@agosmou
Copy link
Contributor

agosmou commented Oct 23, 2023

Problem

There is no existing module for MSSQL for Go

Solution

Adding module for MSSQL

Benefit

Supports MSSQL out of the box

Alternatives

Alternative would be to use generic containers

Would you like to help contributing this feature?

Yes

@agosmou agosmou added the feature New functionality or new behaviors on the existing one label Oct 23, 2023
@mdelapenya
Copy link
Collaborator

Hey @agosmou thanks for opening this issue. Please be my guest and send a PR with it. Of course let me know if you have any issue or question during the creation of the module. BTW I do recommend you using the module generator tool for the scaffolding, as it creates the docs page, the testable examples and the basic code for the module.

Do you know our slack: https://testcontainers.slack.com/

Could you share a little bit about your use case, probably related to testing a MS stack, right?

@agosmou
Copy link
Contributor Author

agosmou commented Oct 24, 2023

Hi! Yes, I joined the slack yesterday 👍🏽

I'll get working on it soon! Thanks for the tip on the scaffolding - duly noted.

Use case is related to integration testing Go API with MS SQL Server database

@mdelapenya
Copy link
Collaborator

PTAL https://golang.testcontainers.org/modules/

@mdelapenya
Copy link
Collaborator

You probably want to take a look at this: https://github.com/BraspagDevelopers/testcontainers-canned/blob/master/sqlserver/sqlserver.go

@agosmou
Copy link
Contributor Author

agosmou commented Nov 11, 2023

Jumping into this, this week! I'll keep you posted @mdelapenya 😄

@agosmou
Copy link
Contributor Author

agosmou commented Dec 3, 2023

@mdelapenya, just submitted a PR for this

Thanks for surfacing the scaffolding - it helped a ton! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or new behaviors on the existing one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants