-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: Reduce verbose log output #1984
Comments
I work around by setting the global Logger of tescontainers to ioutils.NopWriter, as following: testcontainers.Logger = log.New(&ioutils.NopWriter{}, "", 0) However it is not documented in official doc and is not straightforward to figure it out. It's still worth to implement its own NopLogger. |
This only partially suppresses the output, there's still a "Ryuk has been disabled [...]" message that is a straight fmt print call:
|
There are a lot of places calling internal "log" as well. I can open a PR if the devs want it |
Hi folks, I'm tackling this issue as part of the revamp for an eventual I like the idea of only adding the default logging hook if and only if the Regarding the Ryuk banner, we encourage its usage, so we'd like to keep it as soon as it's not intrusive. |
Hi folks, I submitted #2624, PLMK what you think. Thanks! |
Thanks @mdelapenya, I'll give this a shot in some OSS projects I maintain over the next few weeks. |
Proposal
The default log output from this package is quite verbose. It would be ideal if the happy path (by default) logged as little as possible and reported only errors. And for those that do want verbose output, there could be a "verbose" flag or setting that could be enabled.
TL;DR - regardless if it's opt-in or opt-out, it'd be nice for this to be configurable.
I added a custom logger, but it only suppressed items 2 and 3 above.
The text was updated successfully, but these errors were encountered: