Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase check time to 60 secs instead of 20 #2581

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

This PR increase the wait time for checking for running containers, from 20s to 60s.

Why is it important?

We have detected some flakiness in this part of the checks at the CI, where containers sometimes take longer to be removed, specially when Ryuk is disabled.

@mdelapenya mdelapenya requested a review from a team as a code owner June 13, 2024 11:45
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Jun 13, 2024
@mdelapenya mdelapenya self-assigned this Jun 13, 2024
Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit e5722f5
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/666adbdb251a8b00086eca40
😎 Deploy Preview https://deploy-preview-2581--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya merged commit b646bba into testcontainers:main Jun 13, 2024
106 checks passed
@mdelapenya mdelapenya deleted the run-checker-improv branch June 13, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant