docs: update contributing guide #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
commented
Jun 14, 2024
thaJeztah
approved these changes
Jun 14, 2024
mdelapenya
added a commit
that referenced
this pull request
Jun 17, 2024
* chore: update make targets * docd: update contributing guides with go.mod and lint work * docs: wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render URL: https://deploy-preview-2586--testcontainers-go.netlify.app/contributing/
What does this PR do?
This PR updates the contributing guide including how to update the codebase when the core go.mod is updated.
It also include info about passing golangci-lint in the codebase (core and submodules).
Finally it updates the makefile to use simpler names.
Why is it important?
Everytime the core go.mod is updated, the changes must be propagated to all the downstream modules.
Related issues