Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong coupling with "alpine:3.2" image in DockerClientFactory #281

Closed
dddpaul opened this issue Jan 24, 2017 · 5 comments · Fixed by #287
Closed

Strong coupling with "alpine:3.2" image in DockerClientFactory #281

dddpaul opened this issue Jan 24, 2017 · 5 comments · Fixed by #287

Comments

@dddpaul
Copy link

dddpaul commented Jan 24, 2017

Hello.

When #267 was merged running docker inside docker works fine :) This feature is very useful for CI pipelines when Jenkins slave executes in Docker container, for example.

But build servers may have partial Internet connectivity - to the local Docker registry only (just like in my case). So despite of wonderful docker-in-docker support build fails nevertheless on DockerClientFactory.instance().client() invoke.

Can we get rid of this builtin image dependency or make it customizable at least? For example, pass image name to DockerClientFactory through environment variable?

@bsideup
Copy link
Member

bsideup commented Jan 24, 2017

Hi @dddpaul,

I suppose #277 will help; we just have to make TINY_IMAGE configurable.

Will it work for you? (properties file configuration of the images)

@rnorth
Copy link
Member

rnorth commented Jan 24, 2017

Yes, sorry - I should have remembered to include this in #277

@dddpaul
Copy link
Author

dddpaul commented Jan 24, 2017

@bsideup Yes it's will be perfect.

@dddpaul
Copy link
Author

dddpaul commented Jan 31, 2017

@bsideup @rnorth Can I help with this issue? I can try to make #277-like PR by myself.

@bsideup
Copy link
Member

bsideup commented Jan 31, 2017

@dddpaul Sure! Fine by me, we're always welcome any contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants