Improve logging in InternalCommandPortListeningCheck (#2984) #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
|
Hey @vcvitaly, Sorry for overlooking this PR. Could you please resolve the conflict? It looks like you have "enable edits by maintainers" disabled, otherwise I'd do it myself :) Thanks! |
…_11_start_issue # Conflicts: # core/src/main/java/org/testcontainers/containers/wait/internal/InternalCommandPortListeningCheck.java
|
@vcvitaly thanks! Merged 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
Mock Server doesn't start after updating to 5.11.0 #2984
When /bin/sh -c $command exists with code 126 (Command invoked cannot execute), the error output is not logged.
An example, /bin/sh is not available starting certain image version:
OCI runtime exec failed: exec failed: container_linux.go:349: starting container process caused "exec: "/bin/sh": stat /bin/sh: no such file or directory": unknown
Such error output could be logged to assist troubleshooting. It shouldn't bloat logs since such outcome is rare.