Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespaces are not trimmed for the values in the testcontainers.properties #3053

Closed
danblack opened this issue Jul 27, 2020 · 2 comments
Closed

Comments

@danblack
Copy link

If there is a whitespace at the end of the last line of the testcontainers.properties, a test will fail with an error's text shown below
Library version: 1.14.3

testcontainers.properties

tinyimage.container.image = nexus.isb/alpine:3.5
ryuk.container.image = nexus.isb/distantcash-docker-hosted/testcontainersofficial/ryuk:0.3.0 

error

org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=xxx/clickhouse-server:latest, imagePullPolicy=DefaultPullPolicy())
           at org.testcontainers.containers.GenericContainer.getDockerImageName(GenericContainer.java:1279)
           at org.testcontainers.containers.GenericContainer.logger(GenericContainer.java:613)
           at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:320)
           ... 71 more

           Caused by:
           com.github.dockerjava.api.exception.BadRequestException: {"message":"invalid reference format"}
@artjomka
Copy link
Contributor

Is it free for taking ? Then I would like to look into it

@bsideup
Copy link
Member

bsideup commented Jul 30, 2020

@artjomka sure, it is yours! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants