Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Bolt log wait strategy more lenient #4455

Merged
merged 1 commit into from Oct 22, 2021

Conversation

fbiville
Copy link
Contributor

@fbiville fbiville commented Sep 8, 2021

Fixes #4454

@fbiville
Copy link
Contributor Author

fbiville commented Sep 8, 2021

I could not find a simple way to write a test around the updated log strategy. I'm open to suggestions.

@bsideup
Copy link
Member

bsideup commented Sep 17, 2021

Hi @fbiville,

I am just wondering - since we're already checking for 200 answer from the API, does it make sense to check for logs in addition to it?

@fbiville
Copy link
Contributor Author

The 200 check is only for the HTTP server (https://neo4j.com/docs/http-api/current/), the other check is for the Bolt protocol (https://7687.org) server which serves another purpose.

@kiview
Copy link
Member

kiview commented Sep 21, 2021

And both servers can become ready independent of each other?

@fbiville
Copy link
Contributor Author

And both servers can become ready independent of each other?

Sorry for the late reply. Indeed, there is no relation between the two. One server being ready does not mean the other is and vice-versa.

@bsideup bsideup added this to the next milestone Oct 22, 2021
@kiview kiview merged commit 1469b22 into testcontainers:master Oct 22, 2021
@fbiville fbiville deleted the issue_4454 branch November 30, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Neo4j] Default wait strategy breaks on IPv6-enabled environments
4 participants