[couchbase] Add support for Couchbase Analytics. #4592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset adds support for the couchbase analytics service, but does not enable it by default because it is a little more resource hungry and some users may not need it out of the box.
kiview
approved these changes
Oct 19, 2021
| @@ -177,6 +202,8 @@ protected void configure() { | |||
| QUERY_SSL_PORT, | |||
| SEARCH_PORT, | |||
| SEARCH_SSL_PORT, | |||
| ANALYTICS_PORT, | |||
There was a problem hiding this comment.
Just wondering if those should be added depending on enabled services. On the other hand, there is no harm in exposing unused ports and it simplifies the code I suppose.
There was a problem hiding this comment.
Yeah that’s a good idea - I‘ll do that in a follow-up PR since it’s a different optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds support for the couchbase analytics service, but
does not enable it by default because it is a little more resource
hungry and some users may not need it out of the box.