Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Make ClickHouseContainer try to use new driver by default #6232

Closed
trolley813 opened this issue Nov 23, 2022 · 1 comment · Fixed by #6236
Closed

[Enhancement]: Make ClickHouseContainer try to use new driver by default #6232

trolley813 opened this issue Nov 23, 2022 · 1 comment · Fixed by #6236
Labels
type/enhancement

Comments

@trolley813
Copy link
Contributor

trolley813 commented Nov 23, 2022 •
edited

Module

Clickhouse

Proposal

In #5474, support of the new com.clickhouse.jdbc.ClickHouseDriver was added. However, the implementation (the getDriverClassName() function) tries to load the older (deprecated) driver first, and the current Clickhouse JDBC distribution still (as of current version at the moment, 0.3.2-patch11) includes the older driver, so the newer one is actually never used.

I believe that the getDriverClassName() should behave the other way round: first try to load the new driver and, if it's not found, fall back to the old one. This was already noticed by user pan3793 but it seems that the comment was ignored.
@eddumelendez
Copy link
Member

@trolley813 Look at this PR. I am closing this and follow the conversation over there.

@eddumelendez eddumelendez closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2022
@trolley813 trolley813 mentioned this issue Nov 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
2 participants
@eddumelendez @trolley813