Ensure readability of MySQL and MariaDB config override #6625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The credit is all yours my friend! |
| @@ -234,8 +240,43 @@ public void testWithAdditionalUrlParamInJdbcUrl() { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| public void testWithOnlyUserReadableCustomIniFile() throws Exception { | |||
There was a problem hiding this comment.
Should I be able to reproduce this setting umask with 027, right?
There was a problem hiding this comment.
Yeah, the test kinda only an "emulation" but I tested my real world setup with this fix using umask 0027.
There was a problem hiding this comment.
PS: I also did run this new test before and after the fix; before the fix it failed and now it passes.
eddumelendez
approved these changes
Feb 16, 2023
|
Thanks for your contribution, @famod ! This is now merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #914, fixes #4952, supersedes (and heavily based on) #5401.
Most credits to @driverpt!