Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate VaultContainer#withLogLevel #6795

Merged
merged 1 commit into from Mar 21, 2023
Merged

Deprecate VaultContainer#withLogLevel #6795

merged 1 commit into from Mar 21, 2023

Conversation

eddumelendez
Copy link
Member

Log level can be configured using env vars. E.g

VaultContainer<?> vault = new VaultContainer<>("vault:1.6.1")
    .withEnv("VAULT_LOG_LEVEL", "info")

@eddumelendez
Deprecate VaultContainer#withLogLevel
8f8b7db 
Log level can be configured using env vars. E.g

```java
VaultContainer<?> vault = new VaultContainer<>("vault:1.6.1")
    .withEnv("VAULT_LOG_LEVEL", "info")
```
@eddumelendez eddumelendez added this to the next milestone Mar 21, 2023
@eddumelendez eddumelendez added the type/deprecation Public APIs are being deprecated but not changed yet label Mar 21, 2023
@eddumelendez eddumelendez merged commit c418598 into main Mar 21, 2023
82 checks passed
@eddumelendez eddumelendez deleted the deprecate_vault_log_level branch March 21, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth Awaiting requested review from rnorth

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
modules/vault type/deprecation Public APIs are being deprecated but not changed yet
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@eddumelendez